Fix direct transpose output offset#146
Merged
romerojosh merged 1 commit intoJun 24, 2026
Merged
Conversation
romerojosh
reviewed
Jun 24, 2026
romerojosh
left a comment
romerojosh
left a comment
Collaborator
There was a problem hiding this comment.
Hi @fallintoplace, thanks for the contribution. This shift_b typo is something I've been aware of for a while but as noted by your PR comment, it doesn't manifest in any runtime issues since this path it only ever exercised with single rank row/column communicators where the shift/shift_b variables are initialized to an offset of 0. Happy to accept the fix once you remove the additional test.
Signed-off-by: Minh Vu <vuhoangminh97@gmail.com>
fallintoplace
force-pushed
the
fix/direct-transpose-offset
branch
from
42ca482 to
6d314ce
Compare
Collaborator
|
/build |
|
🚀 Build workflow triggered! View run |
|
✅ Build workflow passed! View run |
romerojosh
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shift_baccumulator when computing the direct-transpose destination offset.Notes
offsets_a != offsets_bpublic regression is not currently reachable through this branch becausedirect_transposeis selected only when the communication split count is one. The added test keeps the currently reachable path covered on multiple ranks with output halo/padding.Validation
git diff --checkcmake -S . -B build -DCUDECOMP_BUILD_TESTS=ON -DCUDECOMP_TEST_FETCH_GTEST=ONstops during configure becausenvc++is not available in this environment.clang-formatis not available in this environment.